- 01 Aug, 2022 7 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
This ensures we properly leverage the `assetPrefix` for `app`. Note for reviewing the test changes are mostly spacing so hiding that may help. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Fixes: [slack thread](https://vercel.slack.com/archives/C035J346QQL/p1659387244559979)
-
Steven authored
This PR fixes an issue where tests fail because the generated tmp directory already exists. This is likely caused from two tmp dirs being generated in the same millisecond. ``` Failed to create next instance [Error: EEXIST: file already exists, mkdir '/tmp/next-repo-1659368089063/packages'] { errno: -17, code: 'EEXIST', syscall: 'mkdir', path: '/tmp/next-repo-1659368089063/packages' } ``` https://github.com/vercel/next.js/runs/7615808051?check_suite_focus=true -
Alex Castle authored
This PR adds a `fill` attribute to the future image component, that behave similarly to the fill mode on the existing image component. Functionally, it mainly adds `position: "absolute"` and `object-fit: "contain"` to the image element, along with `height: "100%"` and `width: "100%"` to preserve the image aspect ratio. All of these can be overwritten by the user, except for `position: "absolute"`, which will throw an error. This is because changing that property without height and width is likely to cause layout shift. Because we no longer have the wrapper element, this new version of `fill` requires that the user set `overflow: "hidden"` on the parent element themself, if they want that behavior. This PR also includes several runtime checks to catch instances where the fill mode may provide unexpected results. These runtime checks warn if: * The image doesn't have the `sizes` attribute and loads much smaller than the viewport * The containing element does not have `position: "relative"` * The image height value is 0 Co-authored-by:Steven <229881+styfle@users.noreply.github.com>
-
Jiachi Liu authored
When we detect if `reactRoot` rendering should be enabled we `require` the require to check the version. But at that time the `NODE_ENV` isn't set yet. Then the react dev build stays in the `require.cache` that any future require of react will get the wrong build. In that case, React dev bundle is picked in production mode. Fun fact: if you're using hooks, that seem not to effect you, but context consumer works different then you couldn't get the proper context from provider. Fixes #38176 Fixes #38765 Fixes #38332 ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`
-
Jiachi Liu authored
x-ref #39199 The change in #39199 isn't correct. Middleware manifest should only contain middleware route, so that when router navigates, it only try to apply middleware instead of checking all edge routes. This PR also changes the middleware manifest global value from array to object for easier access ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`
-
NikhilNama18 authored
In `Generating paths on-demand` section It was mentioned that `getStaticProps` allows you to control which pages are generated during the build. But `getStaticPaths` will allows us to control which pages are generated during the build. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
-
- 31 Jul, 2022 3 commits
-
-
John Daly authored
## Documentation / Examples Updating the `with-msw` example to use TypeScript - [X] Make sure the linting passes by running `pnpm lint` - [X] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
-
Santi Dalmasso authored
Update `e2e/example.spec.ts` ([/docs/testing](https://nextjs.org/docs/testing#creating-your-first-playwright-end-to-end-test) page) to fix the failed test. Fixes: #39194 ## Bug - [ ] Related issues linked using fixes #number - [ ] Integration tests added - [ ] Errors have helpful link attached, see contributing.md ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using fixes #number - [ ] Integration tests added - [X] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see contributing.md ## Documentation / Examples - [ ] Make sure the linting passes by running pnpm lint - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md?rgh-link-date=2022-07-13T09%3A09%3A13Z#adding-examples)
-
Jiachi Liu authored
## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`
-
- 30 Jul, 2022 3 commits
-
-
Jessica Franco authored
Otherwise build-native fails with "napi: command not found.". Alternatively, this is missing from this package's devDependencies. ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) P.S.: local copy fails `pnpm lint` due to the `target` subfolder with intermediate rust build artifacts... should I add a `.prettierignore` update to exclude `/packages/next-swc/target/`? Co-authored-by:
JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
Jiachi Liu authored
* refactor: simplify middleware execution * remove ssr prop from RoutingItem * fix build
-
Severin Ibarluzea authored
* fix(#11930): rewritten api routes can correctly handle cors in dev mode * test that request matches hot reloader middleware instead of api https://github.com/vercel/next.js/pull/38937#pullrequestreview-1055957698 * remove unnecessary imports * remove unused constant * remove api route import
-
- 29 Jul, 2022 11 commits
-
-
Jiachi Liu authored
Previous next versions supported nested version of middleware, now we simplify it to one global middleware. This PR clarify the middleware and edge functions usage in dev server
-
Baris Sayil authored
- [x] Simply fix a typo.
-
JJ Kasper authored
-
JJ Kasper authored
-
Jiachi Liu authored
Add `next/dist/client/components/shared/dynamic` as shared api which server and client components can both support. Dynamic imports will be part of flight on server side. This pr doesn't contain preloading part for client components.
-
JJ Kasper authored
-
JJ Kasper authored
-
Donny/강동윤 authored
This PR applies - https://github.com/swc-project/swc/pull/5333 - Closes https://github.com/vercel/next.js/issues/39090
-
JJ Kasper authored
-
JJ Kasper authored
-
JJ Kasper authored
-
- 28 Jul, 2022 14 commits
-
-
Tim Neutkens authored
Cleans up both Flight plugins and leverages type inference more. - Rename plugin - Update name - Remove note on webpack5 - Add types for Flight manifest - Use webpack5 type and tapPromise - Remove any ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
-
JJ Kasper authored
-
JJ Kasper authored
* Ensure we hard navigate for failed _next/data with middleware * fix-lint
-
Houssein Djirdeh authored
Closes: #30962 This PR adds a new `onReady` prop to `next/script` to handle shortcomings of the current `onLoad` prop. Some third-party providers and widgets require initialization code to run after the script's `load` event and every time the component is mounted. The `onReady` should solve that use case. For more details, refer to the discussion in #30962. CC @janicklas-ralph ## Bug - [X] Related issues linked using `fixes #number` - [X] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Co-authored-by:JJ Kasper <22380829+ijjk@users.noreply.github.com>
-
Keen Yee Liau authored
* test: cleanup telemetry integration test Instead of constantly parsing the console output, parse the output once, convert the entries in JavaScript objects, then compare them logically rather than textually. * Collect telemetry for next/future/image Track adoption of next/future/image and add relevant test.
-
JJ Kasper authored
-
Donny/강동윤 authored
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
-
Lafif Astahdziq authored
The commit https://github.com/vercel/next.js/commit/0a781dd67510b679db178b17e30a1a06bb912398 changes the docker examples to use `if..elif..else` it is working fine tor the `with-docker` example, but not working for the `with-docker-compose` and `with-docker-multi-env` examples due to a missing semicolon. Fix #39085 ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
-
Tim Neutkens authored
-
JJ Kasper authored
This corrects some unhandledRejection errors showing when a connection is canceled with the edge runtime since the changes needed for https://github.com/vercel/next.js/commit/14463ddd10eb24c308c96df12874fb9862abefe4. This also adds a regression test to ensure we don't have these class of errors in our middleware tests. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Fixes: [slack thread](https://vercel.slack.com/archives/C03Q1UU3Z4H/p1658960102013969)
-
nasso authored
This seems to be what is recommended by the Cypress documentation: https://docs.cypress.io/guides/references/configuration ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
-
JJ Kasper authored
-
JJ Kasper authored
-
JJ Kasper authored
This ensures we properly update the query when doing a shallow navigation with middleware present and expands our test coverage of this kind of navigation. This also adds middleware rewrite coverage for the case described in https://github.com/vercel/next.js/issues/38405 and ensures we properly resolve dynamic middleware rewrites which was causing https://github.com/vercel/next.js/issues/39049 Test deployment with fix can be seen [here](https://middleware-i18n-redirect-repro-8jd3x47j9-ijjk-testing.vercel.app/gsp/first) and [here](https://nextjs-middleware-rewrite-l6q20cwo3-ijjk-testing.vercel.app/) ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Fixes: https://github.com/vercel/next.js/issues/38495 Fixes: https://github.com/vercel/next.js/issues/39049 Fixes: https://github.com/vercel/next.js/issues/38405
-
- 27 Jul, 2022 2 commits
-
-
Shu Ding authored
(For context, the logic and tests have been moved to `app-render`.) ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
-
Max Proske authored
Converted `cms-agilitycms` example to TypeScript to match Contribution docs. ## Documentation / Examples - [X] Make sure the linting passes by running `pnpm lint` - [X] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
-