- 02 Dec, 2022 4 commits
-
-
JJ Kasper authored
-
JJ Kasper authored
-
JJ Kasper authored
This test was ensuring `app` directory is working correctly with `output: 'standalone'`. Instead of removing config we should conditionally set it for the test. Reverts vercel/next.js#43607 x-ref: https://github.com/vercel/next.js/actions/runs/3594732606/jobs/6055832699 x-ref: https://github.com/vercel/next.js/actions/runs/3594732606/jobs/6055832421
-
Steven authored
This improves the examples and ensures the config at the beginning will work for each of the examples below.
-
- 01 Dec, 2022 14 commits
-
-
Amy Burns authored
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Alexis Rico authored
The deploy button of the `with-xata` example is not working properly because we were lacking the integration to configure the env variables. [](https://vercel.com/new/git/external?repository-url=https://github.com/SferaDev/nextjs-demo/tree/fix-with-xata-deploy/examples/with-xata&project-name=with-xata&repository-name=with-xata&integration-ids=oac_IDpMECDuYqBvAtu3wXXMQe0J) Taking advantage of the PR, some other changes: - Adding `alt` to `next/image` to fix build with latest version - Update readme to add more information in the Xata CLI section - Use a new command to initialize the database schema on first deployment - Remove hardcoded URL in `xata.codegen.ts` - Remove deprecated `formatVersion` in `schema.template.json` - Update dependencies Note: The integration is still work in progress, it works for the `Deploy to Vercel` button but we want to improve the UI/UX before submitting it to the Marketplace, keeping it unlisted for a while.
-
Wyatt Johnson authored
-
Balázs Orbán authored
-
Josh Slate authored
I updated the `active-class-name` example to stop using the legacy behavior. ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm build && pnpm lint` - [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Balázs Orbán authored
Follow-up of #43228. This PR adds a new [GitHub Action](https://github.com/github/issue-labeler) that matches the issue's body for the [dropdown list items](https://github.com/vercel/next.js/blame/6cacd5a7c46fb1bb86c536031140da92863ce451/.github/ISSUE_TEMPLATE/1.bug_report.yml#L26-L48) and adds the relevant labels to the issue for triaging automatically.
-
JJ Kasper authored
-
Hannes Bornö authored
Currently when there's a runtime error - the error overlay opens up in full screen mode. In app it should open in the minimized state. Build errors will still have to open up in full screen since the app will not be runnable due to it being broken. Before  After  Fixes #43460 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Bruno Nascimento authored
fixes #43392 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change that you're making: --> ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [] Related issues linked using `fixes #number` - [] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Valentin Hervieu authored
## Bug Fixes #42621 - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see `contributing.md` Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Max Proske authored
Fixes pnpm w/ example being the only test outside the test suite. Before: ```ts describe('create next app', () => { // ... }) it('should infer pnpm as the package manager with example', () => { ... }) ``` After: ```ts describe('create next app', () => { // ... it('should infer pnpm as the package manager with example', () => { ... }) }) ``` ## Documentation / Examples - [X] Make sure the linting passes by running `pnpm build && pnpm lint` -
Ngô Đức Anh authored
Fix `Failed to copy traced files` for Edge functions and handle its files with middleware-manifest.json (#43326) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change that you're making: --> ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) fixes: #41395 fixes: #42751. This PR is a follow-up PR of [PR 43304](https://github.com/vercel/next.js/pull/43304). This fix works by checking if the page is listed in middleware-manifest.json's functions, if true then skip the handleTraceFiles process. This also fixes the two issues aforementioned by copying files listed in middleware-manifest.json for those pages. Co-authored-by:
JJ Kasper <jj@jjsweb.site>
-
Leonardo Ortiz authored
Group imports from the same source that were separated
-
Steven authored
This PR remove `React.useState()` from the `next/image` component. It was only used in the `onError` case and it was causing Safari to become very slow when there were many images on the same page. We were seeing 1s delay blocking the main thread when there were about 350 images on the same page. Chrome and Firefox were not slow.
-
- 30 Nov, 2022 9 commits
-
-
Balázs Orbán authored
-
Balázs Orbán authored
-
Thai Pangsakulyanont authored
Clarify that publicRuntimeConfig and serverRuntimeConfig do not work with Output File Tracing (#43443) The **Output File Tracing** page mentioned that `publicRuntimeConfig` and `serverRuntimeConfig` are now legacy and does not work with Output File Tracing (they are _inlined at build-time_ instead of being set at runtime, the way it is supposed to work). <img width="710" alt="image" src="https://user-images.githubusercontent.com/193136/204200235-e7570c64-b760-48a8-bd72-46ed27e82363.png"> However, the Runtime Config page itself does not mention this at all. This led me into a wrong path for a while. ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Co-authored-by:
Steven <steven@ceriously.com> Co-authored-by:
Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
-
Aaron Yarborough authored
Co-authored-by:Balázs Orbán <info@balazsorban.com>
-
Balázs Orbán authored
-
Max Proske authored
Simplified the example to just the specific feature, and converted to TypeScript. - `node-fetch@2` is either polyfilled by Next.js or a peerDep of `@vercel/fetch`, I can't quite tell, but either way it can be removed from the dependencies. ## Documentation / Examples - [X] Make sure the linting passes by running `pnpm build && pnpm lint` - [X] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
-
Balázs Orbán authored
-
Jiachi Liu authored
Related to the build failure from #41931 We need to bundle `next/head` so that it can appear in the flight-client-manifest, so we changed the behavior to not treat it as non externals. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)
-
- 29 Nov, 2022 13 commits
-
-
Shu Ding authored
Currently the generated matcher will be `"regexp": "^\(group\)/group$"` for groups which doesn't match the correct route. This is somehow related to #43458, but it only fixes the problem partially. Some other changes need to be made in the build process. ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Balázs Orbán authored
Co-authored-by:
Steven <steven@ceriously.com> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Balázs Orbán authored
-
Balázs Orbán authored
-
Balázs Orbán authored
-
Matthew Heath authored
This PR adds an example `yarn up` command to bump the relevant dependencies when using yarn berry for the Next 12 to Next 13 upgrade. One thing to possibly note is that `yarn up` is not scoped to a single workspace like `yarn upgrade` in classic - to get around this when in multiple workspaces, the `-i/--interactive` flag can be passed. **Update** - can upgrade dependencies in both yarn classic/berry using `yarn add ...@latest`, this may be more straight forward than having two separate commands. ## Documentation / Examples - [X] Make sure the linting passes by running `pnpm build && pnpm lint` - [X] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Balázs Orbán authored
Co-authored-by:
Steven <steven@ceriously.com> Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Max authored
Fixes https://github.com/vercel/next.js/issues/43512
-
Alan Toa authored
# Why hey, teams! since Safari `v16` is supported [resolution media query](https://developer.apple.com/documentation/safari-release-notes/safari-16-release-notes), so this before docs the `@media not all and (min-resolution: 0.001dpcm)` media query will not work on Safari latest version.  so I update the docs for `next/image` [Known Browser Bugs](https://nextjs.org/docs/api-reference/next/image#known-browser-bugs), hope this can help developers. ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm build && pnpm lint` Co-authored-by:
Steven <steven@ceriously.com>
-
Shu Ding authored
This PR adds proper cleanup step for ~`edgeServerModuleIds`, `serverModuleIds` and~ `flightCSSManifest`, which was previously missing. Otherwise it will grow indefinitely during development. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Co-authored-by:
kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
Hannes Bornö authored
When calculating the avg width it's possible for `fontkit` to throw if it can't get the width of the glyphs for a font file. In that case skip the `size-adjust` property and use the other overrides. https://github.com/vercel/next.js/discussions/41745#discussioncomment-4245120 here's an example of an error thrown by fontkit. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
-
Lee Robinson authored
This has been working well in the beta docs, testing on stable docs before we consider doing this with more pages in a more structured way.
-
JJ Kasper authored
-