- 30 May, 2024 13 commits
-
-
vercel-release-bot authored
-
Vercel Release Bot authored
This auto-generated PR updates font data with latest available Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Jiwon Choi authored
cc @ijjk @samcx Revert removed flags from lint-staged. x-ref: https://github.com/vercel/next.js/pull/65861#issuecomment-2140007873
-
DHRUV KAUSHIK authored
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> ### fix Typescript assignment error Co-authored-by:
Sam Ko <sam@vercel.com>
-
yasmin p authored
Replaces inline styles in the Tailwind `create-next-app` templates with classnames to set the font family. Co-authored-by:Sam Ko <sam@vercel.com>
-
Arno authored
Updated the nginx link; they changed domains from https://www.nginx.com/ to https://nginx.orgCo-authored-by:
Sam Ko <sam@vercel.com>
-
Wyatt Johnson authored
This modifies the patched fetch implementation to better handle when called within an `unstable_cache` callback. In these callbacks, it should not throw an error related to dynamic access. This replaces the verbose `trackDynamicFetch` instead with `markCurrentScopeAsDynamic` which already has support for checking if inside an unstable cache context. It also has been adjusted to be a no-op when `export const dynamic = "force-static"`, further simplifying the code within the patch fetch implementation.
-
Sebastian Silbermann authored
-
notomo authored
Co-authored-by:Jiachi Liu <inbox@huozhi.im>
-
Tim Neutkens authored
## What? Ensures `next build` does not fail with Turbopack on `test/e2e/app-dir/rsc-basic/rsc-basic.test.ts`. Gets 36 extra tests passing for Turbopack build. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Jiachi Liu authored
### What Use `next-flight-loader` to transform the client components into client reference in middleware and instrumentation. Add related required webpack aliases, such as alias for `react-server-dom-webpack` ### Why issue reported in https://github.com/vercel/next.js/pull/65424#issuecomment-2128902585
-
Jiachi Liu authored
### What Add copy stack trace button to copy the original stacktrace in error overlay. It will be a dimmed red button with disallowed cursor when it's found not able to copy. #### Video https://github.com/vercel/next.js/assets/4800338/c44e0bf8-f340-41ba-8ee8-4b94fdc298e1 ### Why Makes error reporting easier, users can do one-click to copy the original text
-
Jiwon Choi authored
### Why? The current `lint-staged` hook uses [function signature](https://github.com/lint-staged/lint-staged?tab=readme-ov-file#function-signature) to target the **staged files** and has extra steps for handling those files that seem to have been passed on from a [5-year-old legacy code](https://github.com/vercel/next.js/pull/9245). The entire process is unnecessary today since `lint-staged` only runs on the staged files. ### How? This PR removed unnecessary logic, removed some no-effect flags, and [removed `git add`](https://github.com/lint-staged/lint-staged?tab=readme-ov-file#v10). > If your task previously contained a git add step, please remove this. --------- Co-authored-by:
Sam Ko <sam@vercel.com>
-
- 29 May, 2024 14 commits
-
-
vercel-release-bot authored
-
Jiachi Liu authored
### What Removing the `/[...catchall]/<metadata image convention>.js` case from docs ### Why Since og image and icon routes are using catch-all routes to handle the both single or multiple routes. For instance: `app/opengraph-image.js` can possibly generate two cases: - single route: `/opengraph-image` - multi routes with `generateImageMetadata()`: `/opengraph-image/[id]` We're not able to detect if there's `generateImageMetadata` defined in the file before mapping the routes, and decided to create the different routes to either `/opengraph-image` or `/opengraph-image/[id]`. That's why we're using a catch-all routes to handle them rn. Related #48106 Related #57349
-
조계진 authored
### What? Because `createMultiHtmlMatcher` does not use `await` keyword internally and is not an async function, all `await` in front of the match function returned from `createMultiHtmlMatcher` was removed in `test/e2e/app-dir/metadata/metadata.test.ts`. The JSDoc for `createMultiHtmlMatcher` was also modified. Co-authored-by:Jiachi Liu <inbox@huozhi.im>
-
Wyatt Johnson authored
In preparation for the following request adapter work, this removes a helper function for checking if a request is an RSC one, instead preferring to use the metadata directly. This helps readability because we know where it's coming from, and it keeps the implementation simple.
-
Rishabh Poddar authored
Updates to using latest supertokens' SDK versions. Co-authored-by:Sam Ko <sam@vercel.com>
-
alpedia authored
### What? Removed experimental [mdxRs](https://nextjs.org/docs/app/api-reference/next-config-js/mdxRs) from [pageExtensions](https://nextjs.org/docs/app/api-reference/next-config-js/pageExtensions) ### Why? The pageExtensions setting demonstrates how to allow other extensions like .md and .mdx. The inclusion of the experimental Rust MDX compiler is unnecessary and can lead to confusion. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
samcx <sam@vercel.com>
-
Sebastian Silbermann authored
-
vercel-release-bot authored
-
JJ Kasper authored
Ensures we can cut premajors for canary the same as release-candidate tags.
-
Tim Neutkens authored
Reverts vercel/next.js#66298
-
Will Binns-Smith authored
-
Hendrik Liebau authored
This allows us to set breakpoints and debug e2e tests without encountering a timeout after 60 seconds. For example, using: ``` NEXT_E2E_TEST_TIMEOUT=1000000 NODE_OPTIONS=--inspect-brk pnpm test-dev test/e2e/app-dir/metadata/metadata.test.ts ``` Notably, this change also affects the turbopack dev tests in the CI, where `NEXT_E2E_TEST_TIMEOUT` is currently set to 240 seconds. Since the same env variable is also used for `jest.setTimeout()`, a test timeout will now most likely occur due to jest timing out, and not a specific playwright check (i.e. `waitForElementByCss` or `waitForCondition`) timing out. This sounds acceptable to me. Co-authored-by:JJ Kasper <jj@jjsweb.site>
-
Sam Ko authored
## Why? Upgrade `@capsizecss/metrics` package to the [latest](https://github.com/seek-oss/capsize/releases/tag/%40capsizecss%2Fmetrics%403.2.0).
-
Sam Ko authored
## Why? We get this error when we use `npx` to download the reproduction-template.  Updating the template should fix this error.
-
- 28 May, 2024 13 commits
-
-
vercel-release-bot authored
-
Jiachi Liu authored
x-ref: #65507 Updating the dynamic sitemap routes output url to the one without `.xml` extension
-
Will Binns-Smith authored
This includes an update to lightningcss to 1.0.0-alpha.57 vercel/turbo#7986 vercel/turbo#8218 vercel/turbo#8222
-
Jiachi Liu authored
### What * Error on case that readable stream controller tries to close but stream is either errored or unfinished * Delay the DOMContentLoaded event to avoid "Connection Closed" error ### Why Regarding to the new error about readbale stream controller, the new error we added here is for identifying the connection is closing before the last bit has been received that's an error case not intentional close. It's not a proper state for close more for erroring. As for adding the queuing for the task of dom content loaded callback, after investigation, I found that if the DOMLoaded execute earlier the readable stream controller cuold close earlier on client, which lead to the "Connection Closed." error. Hence we added a `queueMicroTask` here to delay it after hydrate call. x-ref: [slack thread](https://vercel.slack.com/archives/C01A2M9R8RZ/p1715188343813489)
-
Sebastian Silbermann authored
`gh auth status` works: https://github.com/vercel/next.js/actions/runs/9216143946/job/25355841804#step:4:16 We should fail early to hopefully get a better error message if authentication with the configured token fails.
-
Donny/강동윤 authored
### What? Update `lightningcss` **crate**. ### Why? x-ref: https://vercel.slack.com/archives/C04KC8A53T7/p1716896534206159 ### How?
-
Jiachi Liu authored
### What It's not helpful to see the network issue of fetching error on reading nextjs version in dev overlay ### Why Error case: <img width="400" src="https://github.com/vercel/next.js/assets/4800338/a7852d9b-1f98-4098-8498-a3b832efdbb0"> This should just be ignored, it's fine that the fetching is failed. There're so many fetch errors code, it's easy to try-catch on fetch instead of enumerate all the codes
-
Hendrik Liebau authored
Using the hostname `::` enables dual-stack support. This prevents `ECONNREFUSED` errors when running tests locally, and `localhost` being resolved to `::1` (IPv6) instead of `127.0.0.1` (IPv4).
-
Shubh Porwal authored
Updates `with-react-hook-form` example by bumping react-hook-form and other dependencies to their latest versions, along with a minor cleanup of the UI. --------- Co-authored-by:Sam Ko <sam@vercel.com>
-
vercel-release-bot authored
-
📝 Kwon SeungMin authored -
Wyatt Johnson authored
During integration testing, previously, calls to `next build` could rely on the project (the Next.js project) level ESLint configuration. In order to correct this, a new `lint` option was added to `nextBuild` that can be passed to enabled linting. If this is `false` or `undefined`, a `--no-lint` argument will be passed to `next build` to prevent it from running.
-
Wyatt Johnson authored
Old logic from the pages router was previously being hit during development. This was more apparent when PPR was enabled as it was mixing dynamic + static rendering in development which propagated to errors. This change ensures that requests that are made with `RSC: 1` are not marked as `/_next/data` URL's, and don't use the same logic paths. Previously it was a bit confusing because we used the variable `isDataReq` in a few places that made it hard to tell what it was referring to. In this case, the `isDataReq` is actually only used by the pages router. This renames the `isDataReq` to `isNextDataRequest` to make it clearer, as well as refactors to ensure that it's not used in the paths for app routes. Also to better represent the rendering modes the `supportsDynamicHTML` variable was renamed to `supportsDynamicResponse`. Fixes #66241
-