- 03 Dec, 2025 4 commits
-
-
vercel-release-bot authored
-
JJ Kasper authored
-
Josh Story authored
* Update React Version Update React Version * Disable some tests that fail spuriously. Should improve test coverage of otherwise blocked tests
-
JJ Kasper authored
-
- 22 May, 2025 2 commits
-
-
vercel-release-bot authored
-
Zack Tanner authored
In 15.1, this branch should be a no-op when PPR is not enabled, because `collectSegmentData` is [gated](https://github.com/vercel/next.js/blob/69afa37323610c9bbfbecd22f0194f2f299d5a6c/packages/next/src/server/app-render/app-render.tsx#L4008) on `isRoutePPREnabled`. This also sets a no-store cache header when we respond with a 204 to align with intended behavior.
-
- 17 Feb, 2025 2 commits
-
-
Janka Uryga authored
- Fixes an issue where `after()` in an edge page would not run if the request was cancelled/aborted - Unskips the `runs callbacks if redirect() was called` test which was disabled to not block other things This was initially hit in #75882, during which the `runs callbacks if redirect() was called` test started failing when using experimental react + turbo in dev mode. Turns out that this happenws because something got slower and we weren't finishing the redirect response in time, i.e. before the browser disconnected and started loading the page it got redirected to. It's relevant that the response didn't finish streaming, because in `edge`, we use that as the trigger to start running `after()` callbacks. In particular, we instrument the response stream using `trackStreamConsumed`. The problem was that this function didn't handle the stream being cancelled, which is what happens when a request is aborted mid-streaming, so `after()` never ended up executing. This PR fixes that and adds some tests for cancellation and interrupted streaming.
-
Jan Amann authored
Fixes https://github.com/vercel/next.js/issues/69000 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
Zack Tanner <1939140+ztanner@users.noreply.github.com> Co-authored-by:
Sam Ko <sam@vercel.com>
-
- 11 Feb, 2025 1 commit
-
-
vercel-release-bot authored
-
- 10 Feb, 2025 6 commits
-
-
Zack Tanner authored
Backports: - #75727 Co-authored-by:Janka Uryga <lolzatu2@gmail.com>
-
Sebastian "Sebbie" Silbermann authored
-
JJ Kasper authored
As discussed this replaces our Azure pipelines handling with our own runners instead. This allows us to build the `next-swc` binary to run tests against for Windows when necessary instead of trying to leverage the canary binary which requires any relevant changes to have been published which can cause us to miss Windows specific failures until after a canary is published. This also has the benefit of us being able to consolidate our CI config for Windows/Linux for better consistency. Since running workloads on Windows is slower still this just starts with copying over the tests we had configured previously although we can look at adding more we see useful for catching regressions.
-
Zack Tanner authored
Backports: - #75561
-
Zack Tanner authored
Backports: - #75766
-
Jiachi Liu authored
-
- 22 Jan, 2025 3 commits
-
-
vercel-release-bot authored
-
Zack Tanner authored
Backports the testcase added in https://github.com/vercel/next.js/pull/75167 in [9bf61bc](https://github.com/vercel/next.js/pull/75170/commits/9bf61bc76c25f3eb345aac7db34929ecde232569). Confirmed failure via [this run](https://github.com/vercel/next.js/actions/runs/12898849331/job/35966678688?pr=75170) Adds the fix in [0ab1e32](https://github.com/vercel/next.js/pull/75170/commits/0ab1e32f04f09de2b2651b7e889633e43f4834a2). This change is identical to the code used in canary, which was added as part of the `rootParams` feature via https://github.com/vercel/next.js/pull/73816 ([ref](https://github.com/vercel/next.js/blob/d12e2e82b778eef8393f47944a258a55c6c508fe/packages/next/src/build/static-paths/app.ts#L316-L317)) This regression was caused by `segments` containing all possible segments (including parallel routes), not just the page segment. As a result, `paramKeys` was incorrectly being calculated. We don't need to traverse the segments to determine the param keys: we have the route regex & matcher, it's more reliable to extract it from that.
-
Jude Gao authored
-
- 20 Jan, 2025 1 commit
-
-
Janka Uryga authored
### Overview `next start` stores pending promises passed to `waitUntil` so that we can await them before a (graceful) server shutdown and avoid interrupting work that's still running. The problem here was that this set lives a long time (the whole lifetime of the server), but we weren't removing resolved promises from this set, so we'd end up holding onto them forever and leaking memory. This bug would be triggered by any code using `waitUntil` in `next start` (notably, a recent change: https://github.com/vercel/next.js/pull/74164) ### Details The bug here is that `AwaiterMulti` would hold onto resolved promises indefinitely. `AwaiterMulti` ends up being used by `NextNodeServer.getInternalWaitUntil`, which is what provides `waitUntil` in `next start`. The code was already attempting to clean up promises to avoid leaks. But the problem was that we weren't adding `promise` to `this.promises`, we were adding `promise.then(...)` which is a completely different object. So the `this.promises.delete(promise)` that `cleanup` did was effectively doing nothing, and `this.promises` would keep growing.
-
- 17 Jan, 2025 10 commits
-
-
vercel-release-bot authored
-
Jiachi Liu authored
-
Jiachi Liu authored
-
Jiachi Liu authored
-
Jiachi Liu authored
-
Jiachi Liu authored
-
Jiachi Liu authored
-
Mat Mannion authored
### What? A minor fix to the `package.json` for `@vercel/og`; there is a typo on the SPDX license ID for MPL-2.0 which is causing the license ID to not be correctly extracted by some automated tooling (one example is https://github.com/CycloneDX/cyclonedx-webpack-plugin, meaning that the license ID isn't correctly identified). ### Why? For apps that use automated tooling to generate an exhaustive list of dependencies, it's useful to have the license identified automatically and for this to be a valid SPDX identifier to be able to group dependencies together. Co-authored-by:
Jiachi Liu <inbox@huozhi.im>
-
Jiachi Liu authored
-
JJ Kasper authored
This is follow-up to https://github.com/vercel/next.js/pull/74607 ensuring we also don't lose the revalidate value configured when `notFound()` or similar is used. x-ref: [slack thread](https://vercel.slack.com/archives/C02K2HCH5V4/p1736954974909349)
-
- 07 Jan, 2025 8 commits
-
-
vercel-release-bot authored
-
Janka Uryga authored
Fixes #74062 (`jotai` ran into this error [when they added `"type": "commonjs"` to their package.json](https://github.com/pmndrs/jotai/discussions/2579#discussioncomment-9812492)) > this is a bug in the transform we do when a `'use client'` directive is encountered. I think what's happening is that we're creating a virtual file that uses ESM import/export syntax, but it's called proxy.js (not proxy.mjs), so the `"type": "commonjs" `makes turbopack "correctly" upset at the ESM syntax. https://github.com/vercel/next.js/issues/74062#issuecomment-2555922867 The (slightly kludgy) solution is to use `proxy.mjs` or `proxy.cjs` to force the module format, bypassing the issue where `proxy.js` changes meaning depending on `package.json#type`.
-
JJ Kasper authored
This backports #74577 which ensures we don't lose tags added to a page before notFound() is called.
-
JJ Kasper authored
This backports https://github.com/vercel/next.js/pull/74164 to leverage built-in waitUntil if available instead of using the approach that keeps the stream open until the waitUntil promise resolves. x-ref: [slack thread](https://vercel.slack.com/archives/C02K2HCH5V4/p1736211642221149?thread_ts=1734707275.666089&cid=C02K2HCH5V4)
-
Steven authored
Backport https://github.com/vercel/next.js/pull/74257 to 15.1.x
-
Steven authored
Backport https://github.com/vercel/next.js/pull/73925 to 15.1.x
-
Steven authored
Backport https://github.com/vercel/next.js/pull/73923 to 15.1.x
-
Steven authored
Backport https://github.com/vercel/next.js/pull/73909 to 15.1.x
-
- 26 Dec, 2024 1 commit
-
-
vercel-release-bot authored
-
- 24 Dec, 2024 2 commits
-
-
Zack Tanner authored
Backports: - #74154
-
Zack Tanner authored
Backports: - #73900 Co-authored-by:Hendrik Liebau <mail@hendrik-liebau.de>
-