- 05 Mar, 2025 15 commits
-
-
vercel-release-bot authored
-
Jiachi Liu authored
### What When client sends and Server Action request with `notFound()` inside, next-server will serve the RSC payload in response but we were also serving a fallback `robots=noindex` metadata for 404 requests. This will be a conflict for users custom metadata. The fallback `robots=noindex` for 404 response was for initially for pages rendering request. Here we skip it for the dynamic RSC to avoid user's metadata being de-prioritized due to the fallback `robots=noindex` taking precedence. We also add a test that it won't break form action, where when JS is disabled and notFound involked, the new page can still be served with fallback noindex Fixes NDX-953
-
Janka Uryga authored
`__next_app__.require` and `__next_app__.loadChunk` were typed as `any` for no good reason. i made them more strict + adjusted callsites as needed. also contains a drive-by fix for `wrapClientComponentLoader` -- it was using a `try ... finally` without awaiting, so it wasn't measuring anything (because `loadChunk`, being async, would always return immediately)
-
Vercel Release Bot authored
-
Tobias Koppers authored
### What? * handle task cancelation * wait for stopping turbo-tasks before running exit handlers * sort all output manifests
-
Hendrik Liebau authored
Reflect team changes.
-
Janka Uryga authored
`handleAction` had a weird spot where it'd add a `set-cookie` header if a redirect was thrown during handling a no-js action. AFAICT, this is unnecessary -- we set the `set-cookie` header on the response as soon as `cookies().set()` is called, so there's no need to set the cookies again in that branch of the handler. this is done through a combination of the patched setter from `RequestCookies`: https://github.com/vercel/next.js/blob/0abd87717f19bced6c35af1255837628513cf772/packages/next/src/server/web/spec-extension/adapters/request-cookies.ts#L160-L171 and this cookie updating function from the request store (which `updateResponseCookies` above would invoke with the new cookies): https://github.com/vercel/next.js/blob/0abd87717f19bced6c35af1255837628513cf772/packages/next/src/server/async-storage/request-store.ts#L170-L174 i've also added a test for this specific scenario to ensure that this wasn't actually doing anything useful.
-
Niklas Mischkulnig authored
Should make the output more deterministic. We could change these to instead use our own `SliceMap`, but these aren't stored anywhere.
-
rauno authored
The current animation strategy for our Dev Tools surface does not work. https://github.com/user-attachments/assets/a0ca5459-9d5a-4d90-af00-b071d43581e0 On page load, several animations can be observed: - Width growth from `0` → `auto` - Issue count translates and fades, along with the plural `s` suffix - A subtle scale bounce effect plays All these animations are state transitions, and thus we should ignore them completely on page load or on high-frequency updates where animating is undesirable, e.g. sometimes `issueCount` will receive updates faster than the animation can run. This PR implements checks to guard the animations from being executed on page load, _and only_ during state transitions. To review, it is worth checking out the [/animation-test](https://github.com/vercel/next.js/blob/a6e6fe635b712020d4ea2d027040d838eb5941c6/test/development/app-dir/hydration-error-count/app/animation-test/page.tsx) fixture I've set up in this PR. After these changes, the experience is as follows—no animations on page load, but only on subsequent low-frequency updates (count change, or collapse of the surface): https://github.com/user-attachments/assets/7b2d5e0d-64ec-4165-b5e2-85489bd00a2c _Note: I am not using Storybook for a page load reference, the apps under `test/development/app-dir/*` are more reliable._
-
Sam Ko authored
docs(errors): remove confusing good-to-know since global-errors.tsx also show in dev as of 15.2 (#76825) ## Why? The "Good to know" has a typo, and it is probably better not mentioned. The https://nextjs.org/docs/app/building-your-application/routing/error-handling#handling-global-errors page does not mention (the fact that `global-errors.tsx` now show in `next dev`) it either.
-
Jiachi Liu authored
Add a new page for the experimental flag `viewTransition`
-
Jude Gao authored
Co-authored-by:Jimmy Lai <laijimmy0@gmail.com>
-
Vercel Release Bot authored
-
Sebastian "Sebbie" Silbermann authored
-
Jiachi Liu authored
### What Those metadata were added into error boundaries but they're actually duplicated, we already have the actual metadata in the page and the metadata outlet can trigger the error boundary. The metadata element in the error boundary is not necessary.
-
- 04 Mar, 2025 16 commits
-
-
vercel-release-bot authored
-
Tobias Koppers authored
### What? * avoid single entry sectioned source maps * avoid empty generated source map sections
-
Sam Ko authored
## Why? Updating Tailwind templates to closer match the non-Tailwind template. (before, `localhost:3000` is current Tailwind template) https://github.com/user-attachments/assets/b5bef4c7-0c22-43e2-87f1-2dbd4903ea0f (after) https://github.com/user-attachments/assets/5b1d087c-60e6-45fc-b749-f3894834e339 - Minor fix to `a.secondary` style's `min-width` to be the same width as `a.primary` - --------- Co-authored-by:
Lee Robinson <lee@leerob.com>
-
Steven authored
The docs for `minimumCacheTTL` showed the default but didn't show an example of changing it. Based on looking at many websites and the frequency those images change, I think 31 days is a good choice.
-
Lee Robinson authored
-
Niaz Morshed Nayeem authored
-
Sebastian "Sebbie" Silbermann authored
-
Sebastian "Sebbie" Silbermann authored
Fixes https://github.com/vercel/next.js/actions/runs/13651039022/job/38159568577?pr=76787#step:33:639 Sometimes we didn't get to assert in time before more errors come in. Now the test ensures that each error is intentional.
-
Sebastian "Sebbie" Silbermann authored
-
Sebastian "Sebbie" Silbermann authored
Missing stack tracked in https://linear.app/vercel/issue/NDX-920/
-
Sebastian "Sebbie" Silbermann authored
-
Sebastian "Sebbie" Silbermann authored
-
Sebastian "Sebbie" Silbermann authored
-
Sebastian "Sebbie" Silbermann authored
-
Sebastian "Sebbie" Silbermann authored
-
Sebastian "Sebbie" Silbermann authored
-
- 03 Mar, 2025 9 commits
-
-
vercel-release-bot authored
-
JJ Kasper authored
These are failing our canary only check for stable releases so adds necessary env to avoid this. x-ref: https://github.com/vercel/next.js/actions/runs/13641536096/job/38133462655
-
Jude Gao authored
### What? The behavior of `OPTIONS` requests differs depending on whether the page is an SSG page or not: - For **SSG pages**, we return a `405 Method Not Allowed` status code ([#34346](https://github.com/vercel/next.js/pull/34346)). - Otherwise, when an `OPTIONS` request reaches `doRender`, it returns a `400 Bad Request` ([#65295](https://github.com/vercel/next.js/pull/65295)). However, in the first case, handling the error page triggers a `doRender` call, which inadvertently resets the status code to `400`. We want to ensure it remains `405`. To fix this, I propose **skipping the error page rendering for `OPTIONS` requests on SSG pages** and directly returning `"Method Not Allowed"`. This also addresses several related issues (see "Why"). ### Why? When an `OPTIONS` request is made to an SSG page: 1. **Rendering an error page is wasteful.** A `405` response doesn’t need a UI, so skipping the rendering improves efficiency. 2. **The status code is reset incorrectly.** As described in ["What"], the logic in [`base-server.ts#L2682`](https://github.com/vercel/next.js/blob/canary/packages/next/src/server/base-server.ts#L2682) changes the status code to `400` when rendering an error page. 3. **It triggers a fatal error** (`Error: invariant: cache entry required but not generated`) for projects deployed on Vercel (see: [NEXT-4000](https://github.com/vercel/next.js/issues/4000)). ### How? Instead of rendering an error page, we return a **hardcoded HTML response** with a `"Method Not Allowed"` body. Closes [NEXT-4000](https://github.com/vercel/next.js/issues/4000).
-
Pranathi Peri authored
Small inconsistency between the overflow gradient on the overlay in production and in code. This should fix it :") Before:  After (normal):  After (hover): 
-
vercel-release-bot authored
-
vercel-release-bot authored
-
Will Binns-Smith authored
This adds a snapshot for rspack to this test. It also mentions rspack instead of webpack when failing with build errors. Test Plan: `pnpm test-start-rspack test/e2e/app-dir/use-cache-unknown-cache-kind/use-cache-unknown-cache-kind.test.ts`
-
Sebastian "Sebbie" Silbermann authored
-
Sam Ko authored
## Why? Re-organizing some information across internal Slack channels.
-