- 27 Feb, 2025 30 commits
-
-
vercel-release-bot authored
-
Benjamin Woodruff authored
Reverts vercel/next.js#76606 Causes the nightly jobs to fail with: ``` Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run ``` because we're running two `build_reusable` jobs with the same stepName. While I could fix this, we'd still have problems with either duplicating tests on areweturboyet, or we'd need some logic to merge test results across the matrix. I like the idea of running the full matrix, but this type of thing is rare and maybe not worth solving for (aside from catching it when the PR goes up, which we now have logic for, thanks to @unstubbable).
-
Will Binns-Smith authored
Currently many of our plugins import a singleton mapping of webpack compilation objects to their corresponding tracing span. This change abstracts that away into a function called `getCompilationSpan`, and allows us to use the corresponding mapping in the rspack case. Previously, any plugin that used these would fail with rspack when the compilation object wouldn’t be found. This was the case when running `next build` with rspack. Test Plan: Install and run `next build` with the rspack plugin in a test app.
-
Andrew Clark authored
When a navigation happens and the only thing that changes is the hash fragment, we must do some special handling to ensure that the hash is correctly scrolled into view. Nearly all of this is handled by ScrollAndFocusHandler; for the Segment Cache, the only thing we need to do is update a few of the fields on the router state object, like `scrollableSegments` and `onlyHashChange`.
-
Will Binns-Smith authored
This opts us out of using the native built-in plugins for Rspack for now. The existing swc plugin we use for webpack does additional work beyond just swc transformation, including validating RSC components to make sure they don’t use React APIs unavailable in that context. In total, the native plugins result in a less than 20% performance gain which, while significant, isn’t necessary as we focus on correctness for now. If we decide the maintenance cost of maintaining multiple plugins in parity is worth the performance gain in the future, we can selectively re-enable some or all of these plugins. Test Plan: `pnpm test-dev-rspack test/development/acceptance/server-component-compiler-errors-in-pages.test.ts` no longer fails by missing the invalid React api messages.
-
Sebastian "Sebbie" Silbermann authored
-
Sam Ko authored
## Why? We are not extending the tailwind theme for `--color-background` and `--color-foreground`. (Before) https://github.com/user-attachments/assets/d336dab3-a00f-46cb-9587-055a6c5272fa (After) https://github.com/user-attachments/assets/123e829d-aa7e-4b57-aa21-261fc05350f8 Follow-up fix for https://github.com/vercel/next.js/pull/75407.
-
Niklas Mischkulnig authored
-
Vercel Release Bot authored
This auto-generated PR updates the development integration test manifest used when testing alternative bundlers.
-
Vercel Release Bot authored
This auto-generated PR updates the production integration test manifest used when testing alternative bundlers.
-
Delba de Oliveira authored
- Minor updates to the new Streaming Metadata section - Document new next.config.ts option: `htmlLimitedBots`
-
Delba de Oliveira authored
We added a new option to `devIndicators` (`position`) and removed the previous options from the docs. This PR adds a version history with a note about the deprecated options.
-
Philip I. Thomas authored
-
Jiachi Liu authored
### What `_optOutBundlingPackages` was not used as there's already a optOutBundlingPackagesRegex, removing it from the `handleExternals`
-
Sebastian "Sebbie" Silbermann authored
-
Hendrik Liebau authored
While #76544 doesn't hurt, this is the more important fix to ensure that tests that were previously marked as `failed` are only promoted to `passed` if they also pass when the test is run with React 18.
-
Sebastian "Sebbie" Silbermann authored
-
Sebastian "Sebbie" Silbermann authored
-
Sebastian "Sebbie" Silbermann authored
-
Hendrik Liebau authored
Follow-up for #76544. [Failed worflow run](https://github.com/vercel/next.js/actions/runs/13560755436/job/37903278074) The PR number was incorrectly retrieved from the `octokit.rest.pulls.create` response.
-
Hendrik Liebau authored
[flakiness metric](https://app.datadoghq.com/ci/test/runs?query=test_level%3Atest%20env%3Aci%20%40git.repository.id%3Agithub.com%2Fvercel%2Fnext.js%20%40test.service%3Anextjs%20%40test.status%3Afail%20%28-%40git.branch%3A%2A%3F%2A%20OR%20%40git.branch%3Acanary%29%20%40test.name%3A%22parallel-routes-revalidation%20should%20not%20trigger%20the%20intercepted%20route%20when%20lazy-fetching%20missing%20data%22&agg_m=count&agg_m_source=base&agg_t=count&citest_explorer_sort=timestamp%2Casc&cols=%40test.status%2Ctimestamp%2C%40test.suite%3A83%2C%40test.name%3A607%2C%40git.branch¤tTab=overview&eventStack=&fromUser=false&graphType=flamegraph&index=citest&start=1738068572273&end=1740660572273&paused=false) The latest canary release [failed](https://github.com/vercel/next.js/actions/runs/13555525831/job/37890389323) because the deploy test `parallel-routes-revalidation › should not trigger the intercepted route when lazy-fetching missing data` kept failing even with retries. According to my local testing using `pnpm test-deploy test/e2e/app-dir/parallel-routes-revalidation/parallel-routes-revalidation.test.ts -t 'should not trigger the intercepted route when lazy-fetching missing data'`, the forward navigation was sometimes triggered too early after the page was reloaded. To fix it we're waiting for the idle network event before proceeding with the forward navigation.
-
Niklas Mischkulnig authored
-
Jiwon Choi authored
-
vercel-release-bot authored
-
Jiwon Choi authored
-
Tim Neutkens authored
## What? Follow-up to #76129. Fixes the sourcemap, ensures the mappings are not carried over when compiling for the client. For the server these mappings are preserved. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
-
Donny/강동윤 authored
### What? Update `swc_core` to `v16.0.0`. This is a Wasm-breaking change, and changelog is at https://github.com/swc-project/swc/compare/swc_core%40v14.0.1...swc_core%40v16.0.0 ### Why? To apply various fixes.
-
Rich Haines authored
This PR adds docs for the experimental node.js runtime middleware feature. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by:
Mariano Fernández Cocirio <marianococirio@gmail.com> Co-authored-by:
Lee Robinson <lee@leerob.com> Co-authored-by:
Zack Tanner <1939140+ztanner@users.noreply.github.com>
-
JJ Kasper authored
Continues https://github.com/vercel/next.js/pull/76532 as it seems to be alleviating the `npm` failures so replaces some more usage of global `npm` installing the turbo CLI. x-ref: https://github.com/vercel/next.js/actions/runs/13554859494/job/37886841090#step:15:25
-
Benjamin Woodruff authored
When we break rustdoc, it causes warnings on every PR, e.g:  ...so we should either not check the rustdocs at all, or block on them. This makes them blocking.
-
- 26 Feb, 2025 10 commits
-
-
vercel-release-bot authored
-
Andrew Clark authored
This updates the Form component to use the same visibility tracking implementation as the Link component. It's basically the same changes that were introduced in https://github.com/vercel/next.js/pull/74670. The resulting improvements are the same as those for Link: - Prefetches are initiated directly inside the IntersectionObserver, not in a useEffect. - Prefetches initiated by a form component will be canceled if the form exits the viewport (if the Segment Cache is enabled). - Prefetches will be re-triggered when the cache is invalidated (if the Segment Cache is enabled).
-
vercel-release-bot authored
-
vercel-release-bot authored
-
Zack Tanner authored
When you disable the dev indicator, either with `devIndicators: false` or clicking the hide button, we still show a minimized version so you can open up the error overlay. That version should also be dismissible within the current browser session. https://github.com/user-attachments/assets/bbf114c1-2c73-4051-8fbc-dbd93acb7f64
-
Terry Sutton authored
-
Jiwon Choi authored
### Why? Since the docs button can link to related React docs, rephrase the title to "related documentation" instead of "related Next.js docs".
-
PapatMayuri authored
This PR updates the remove-console example for using the App Router. Here are the changes that have been made: - I renamed the pages folder and moved it to the app folder. - Added the layout.tsx file as part of the App Router. - Updated the package.json file. CC: @samcx --------- Co-authored-by:
MayuriPapat25 <mayuri.papat@qed42.com> Co-authored-by:
samcx <sam@vercel.com>
-
Sam Ko authored
## Why? We should clarify that React will **not** attempt to patch mismatched text content when using `suppressHydrationWarning`. - Related: https://github.com/reactjs/react.dev/pull/7651 - x-ref: https://github.com/vercel/next.js/discussions/75890
-
Jude Gao authored
**Test** Generate a prod build, and search `AppDevOverlayErrorBoundary` in the build output. --- Before the change, `main-app` has an occurrence of `AppDevOverlayErrorBoundary`.  After the change, there should be 0 occurrences: 
-